search

rvanlaar / dokku-nginx-stream

dokku plugin to open TCP ports on the application for the outside world.
12 stars 10 forks source link

SELinux breaks this #2

Closed josegonzalez closed 4 years ago

josegonzalez commented 4 years ago

Rather than including an nginx conf from the app directory, would be better to have an include /etc/nginx/app-stream/*.conf; directive. The filenames would be $APP.conf.

I think the way dokku core has done it is definitely not correct, and we'll be fixing it in the future, but better for you to fix this now than deal with it later.

Note: writing to the /etc/nginx path may require a sudoers entry, not sure.

rvanlaar commented 4 years ago

Made a branch to track these changes: https://github.com/rvanlaar/dokku-nginx-stream/tree/conf-location

rvanlaar commented 4 years ago

Thank you for the feedback. I've incorporated it in the project.