Segment fault on memory exhaustion. Should error out instead.

rvaser / spoa

SIMD partial order alignment tool/library

MIT License

158 stars 32 forks source link

Segment fault on memory exhaustion. Should error out instead. #24

Open paoloczi opened 4 years ago

paoloczi commented 4 years ago

Spoa segment faults if it runs out of memory. Instead, it should throw an exception or return an error code. The attached test program segment faulted on my 32 GB laptop. I realize sequences these long are outside of what spoa can reasonably do, but a segment fault is not an acceptable termination mode, because client code does not get a chance to write a meaningful message for the end user.

testSpoa.cpp.gz

rvaser commented 4 years ago

Hi Paolo, I'll fix this as soon as possible.

Best regards, Robert