search

rvaser / spoa

SIMD partial order alignment tool/library
MIT License
158 stars 32 forks source link

optionally build the graph using reverse complemented alignments #42

Closed ekg closed 4 years ago

ekg commented 4 years ago

Supplying the -R flag to spoa will allow it to build the graph progressively by selecting the better of the forward or reverse complement alignment.

ekg commented 4 years ago

One thing I changed was to comment out the deleted copy and copy reference constructors in the Sequence class. I'm not sure if that's OK because I don't know why you had marked them as deleted. My minimal testing still passed.

rvaser commented 4 years ago

I do not remember why both constructors were deleted. I have to refactor the whole repository anyway :)

ekg commented 4 years ago

What's your refactor for?

On Thu, Jun 25, 2020 at 10:51 AM Robert Vaser notifications@github.com wrote:

I do not remember why both constructors were deleted. I have to refactor the whole repository anyway :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rvaser/spoa/pull/42#issuecomment-649391235, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABDQEJXEVUXJ4ERVGYHLDLRYMFZXANCNFSM4OGVI4WA .

rvaser commented 4 years ago

I have updated all submodules, and have to rewrite some parts of the code here as well.