rvazarkar / NGUInjector

Apache License 2.0
27 stars 31 forks source link

Bug: The automated rebirths don't harvest Yggdrasil and don't use blood NUMBER boosts before rebirthing #93

Open Latecomerr opened 3 years ago

Latecomerr commented 3 years ago

Title says all

masanbol commented 3 years ago

at least for me, ygg harvest does occur. have not tested blood.

Latecomerr commented 3 years ago

at least for me, ygg harvest does occur. have not tested blood.

Level 4 fruit on a 1 hour (and 2 minute) rebirth. Harvests happen when the fruit is at 4/4, but that's not happening with a 1 hour rebirth. After 1 hour, the fruit is at 1/4. Two minutes later, a rebirth happens and the fruit is wasted because it's not being harvested.

Latecomerr commented 3 years ago

Did not gain a single seed over an entire day with 1h2min rebirths - maybe there is some setting I need to toggle to make sure that all fruits are eaten/harvested immediately ahead of an automated rebirth?

Montoyal commented 3 years ago

Same issue, auto rebirths don't seem to harvest before rebirthing and blood gets unused.

smail0r commented 3 years ago

I believe the function PreRebirth() in BaseRebirth.cs is checking for AnyHarvestable() and if there are any it does a HarvestAll(). The HarvestAll() function probably does not work, unlike ActuallyHarvest(), the latter is a private function while the first is a internal static. Unfortunately I don't know any C# but that is where I'd look first. Btw, the 'Harvest All Now' button too doesn't work, at least for me.