codecov-commenter
commented
2 years ago Codecov Report
Merging #32 (7afdb10) into master (c1fd3b4) will increase coverage by
10.68%. The diff coverage is96.74%.
@@ Coverage Diff @@
## master #32 +/- ##
===========================================
+ Coverage 53.16% 63.84% +10.68%
===========================================
Files 39 40 +1
Lines 1454 1524 +70
===========================================
+ Hits 773 973 +200
+ Misses 681 551 -130 | Impacted Files | Coverage Δ | |
|---|---|---|
| src/pyskindose/geom_calc.py | 50.00% <ø> (+12.50%) |
:arrow_up: |
| src/pyskindose/settings_normalization.py | 90.90% <ø> (+70.45%) |
:arrow_up: |
| tests/unittests/test_rdsr_parsing.py | 90.47% <90.47%> (ø) |
|
| src/pyskindose/constants.py | 100.00% <100.00%> (ø) |
|
| src/pyskindose/phantom_class.py | 62.12% <100.00%> (ø) |
|
| src/pyskindose/rdsr_normalizer.py | 98.55% <100.00%> (+77.12%) |
:arrow_up: |
| src/pyskindose/rdsr_parser.py | 82.53% <100.00%> (+74.47%) |
:arrow_up: |
| tests/unittests/test_corrections.py | 100.00% <100.00%> (ø) |
|
| tests/unittests/test_geom_calc.py | 100.00% <100.00%> (ø) |
|
| tests/unittests/test_positioning.py | 100.00% <100.00%> (ø) |
|
| ... and 5 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update c1fd3b4...7afdb10. Read the comment docs.
BwKodex
solves #31.
Started as a suspected bug fix in the dose calculation for Philips SR data. It turned out to be a problem with incorrect parsing of multiple X-ray filter materials.
In addition to the above, some missing imports have been added (black, isort) as well as other small improvements in code readability.