search

rvbCMTS / PySkinDose

MIT License
13 stars 4 forks source link

Fix rdsr normalizer crashes for events with no filter #38

Closed BwKodex closed 2 years ago

BwKodex commented 2 years ago

Adds a fix for the RDSR normalizer crashing on normalizing the X-Ray filter material thickness for events that have no filter. See bug report #37.

Also cleans up the RDSR parser/normalizer test code a bit by moving them into separate integration test files

codecov-commenter commented 2 years ago

Codecov Report

Merging #38 (989f7d2) into master (2c55285) will increase coverage by 0.78%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   64.10%   64.89%   +0.78%     
==========================================
  Files          40       42       +2     
  Lines        1524     1558      +34     
==========================================
+ Hits          977     1011      +34     
  Misses        547      547
Impacted Files Coverage Δ
tests/unittests/test_geom_calc.py 100.00% <ø> (ø)
tests/unittests/test_positioning.py 100.00% <ø> (ø)
src/pyskindose/constants.py 100.00% <100.00%> (ø)
src/pyskindose/phantom_class.py 62.12% <100.00%> (ø)
src/pyskindose/rdsr_normalizer.py 98.64% <100.00%> (+0.09%) :arrow_up:
tests/integrationtests/conftest.py 100.00% <100.00%> (ø)
tests/integrationtests/test_rdsr_normalizer.py 100.00% <100.00%> (ø)
tests/integrationtests/test_rdsr_parser.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2c55285...989f7d2. Read the comment docs.