search

rvbCMTS / PySkinDose

MIT License
12 stars 4 forks source link

Adds handling of miss-matching blank spaces in device names #43

Closed BwKodex closed 2 years ago

BwKodex commented 2 years ago

Fixes bug that caused the calculation_k_tab function in corrections.py to crash when Allura Clarity was spelled with a blank space between the two words instead of in Pascal casing as used in the database. As discovered in #27

Also fixes a unit test of the calculate_k_tab function that previously did not actually check the output of the function.

Solves #41

codecov-commenter commented 2 years ago

Codecov Report

Merging #43 (2050237) into master (2dfa031) will increase coverage by 0.75%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
+ Coverage   64.82%   65.57%   +0.75%     
==========================================
  Files          42       42              
  Lines        1555     1560       +5     
==========================================
+ Hits         1008     1023      +15     
+ Misses        547      537      -10
Impacted Files Coverage Δ
src/pyskindose/constants.py 100.00% <100.00%> (ø)
src/pyskindose/corrections.py 95.91% <100.00%> (+20.91%) :arrow_up:
tests/unittests/test_corrections.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2dfa031...2050237. Read the comment docs.