search

rvcas / room

A Zellij plugin for quickly searching and switching tabs 🖤
MIT License
150 stars 14 forks source link

add emacs navigation keys #11

Closed svonjoi closed 2 months ago

svonjoi commented 3 months ago

This would be very usefull

C-p == arrow up C-n == arrow down

rvcas commented 3 months ago

@svonjoi no problem, I'll make it happen

rvcas commented 3 months ago

@svonjoi ok so one problem is that Ctrl-p is already used by zellij for the pane mode toggle. So might be bad UX to use that as a shortcut for moving up and down?

svonjoi commented 3 months ago

This keybinds are part of readline library that is usually integrated in shells and provide some emacs keybinding for line editing in CLI. So the default zellij keybinds rewrite this line-editing capabilies and also conflicts with some neovim functionallity. There is a "tmux mode" that workaround all possible conflicts so finally you only have 1 zellij keybind and this is the best way imho

svonjoi commented 3 months ago

for example history readline keybinds. here are listed all history related keybinds, and also the C-p, C-n that acts as arrow keys

svonjoi commented 3 months ago

if you consider this ok, a option could be make configuration parameter to activate this keybinds and set to false by default

rvcas commented 3 months ago

@svonjoi understood, I'll make it a config option. Sorry for the delay.

svonjoi commented 1 month ago

hey thank you

@svonjoi ok so one problem is that Ctrl-p is already used by zellij for the pane mode toggle. So might be bad UX to use that as a shortcut for moving up and down?

so i see this feature work if zellij default keybinds are rewritten in config with clear-defaults=true so C-p is liberated. its cool