search

rvdbreemen / OTGW-firmware

A ESP8266 devkit firmware for the Nodoshop version of the Opentherm Gateway (OTGW)
MIT License
145 stars 34 forks source link

Are there any way to block the public wifi when router is offline? #131

Closed rotilho closed 1 year ago

rotilho commented 1 year ago

I had to disconnected my router for several hours few days ago and I noticed the gateway starts the public wifi after some time but reconnects if my router comes back online.

Are there any way to block that? I don't want to expose my boiler if my router is offline so it would great if the gateway stick to the configured wifi.

rvdbreemen commented 1 year ago

Well. The whole setup was made so with intermittent WiFi it just recovers. No open WiFi. But after an extended period it will assume it needs to be reconfigured that's why you see the WiFi auto configuration portal pop up.

If you restore wifi it should recover without an issue, even when it is already in configuration mode.

Not sure how to improve this behavior to be honest without losing functionality. Any suggestions?

rotilho commented 1 year ago

I understand that for first install it totally makes sense but after it's already configured I'd expect that I would have to reset it to pair to a new network. This is similar behavior to ESPHome (when the wifi credentials are not compiled together) and most of Zigbee devices.

I just want to avoid that technical issues with my router cascade to my boiler being exposed.

rvdbreemen commented 1 year ago

So you are suggesting that you should reset after a certain amount of time to recover when an WiFi PSK or SSID changes?

It that the fix your are proposing?

rotilho commented 1 year ago

Slightly different. What I'm proposing is:

In this way the boiler is never exposed due to some issue with the router and just a person with physical access to the gateway is able to change the wifi

I understand it's less practical than current set up but it's way more secure.

tjfsteele commented 1 year ago

That's not a great idea for those of us who can't easily access our OTGW.

Tim

On Sun, 21 Aug 2022 at 20:54, Felipe Rotilho @.***> wrote:

No no no, sorry. What I'm proposing is:

  • If there's no wifi configured: gateway create a public wifi so we can configure it
  • If there's an wifi configured and it's not connected: keep retrying every X time
  • If there's an wifi configured and I want to change the wifi: I need to manually reset the gateway with the physical reset button in the gateway

— Reply to this email directly, view it on GitHub https://github.com/rvdbreemen/OTGW-firmware/issues/131#issuecomment-1221610359, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN3CV4BXXRZD3KZHVXRUVT3V2KCOVANCNFSM542FZNAA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

dwar commented 1 year ago

I think this is a security vulnerability! The wifi credentials are stored on esp.

DutchEngineer commented 1 year ago

Would it be an option to always have a password in AP mode? Having a default password after flashing the firmware. And having the option to change the password in the settings. This way we would keep all the features while still having some security?

0crap commented 1 year ago

I think this is a security vulnerability! The wifi credentials are stored on esp.

  • Jam the wifi until the recovery AP should be up. (in my case random dropouts :-( )
  • Connect to the AP before the esp reconnects to the original wifi.
  • Upload new firmware which exposes the wifi password.
  • Your in

If this is true then this issue needs urgent attention! The OTGW uses standard telnet and a webGUI without any authentication, which is already not the greatest idea. However, if it's possible to extract the WiFi password in whatever way, that is a serious vulnerability that needs patching.

For the initial setup it's fine as it is, but after it's connected to the WiFi network it should only retry on disconnect. If you need to change the network or WiFi password, just flash the WeMos D1 to the initial setup config. Could that be a simple solution to quickly mitigate this issue?

There is no excuse to leave this vulnerability in. A large amount of users will never change the WiFi password, that's why it must stay safe at all cost. (Just stay on the old OTGW firmware if you don't care about security.)

Hope this gets fixed soon. 👍

rotilho commented 1 year ago

That's not a great idea for those of us who can't easily access our OTGW. Tim

Tim, I understand your perspective. While it is true that improving security often involves making some sacrifices in terms of user experience, I believe that the default setting should always prioritize security. If users are comfortable with the less secure option, they can opt in.

rvdbreemen commented 1 year ago

In v0.10.0 now can no longer just "flash" the firmware from the Hotspot mode anymore. I think this improves security a little, but not enough yet. However, I am not sure if I want to make it more difficult to reconfigure the wifi for users.

You are welcome to do a PR to improve the security more.