rvdbreemen / OTGW-firmware

A ESP8266 devkit firmware for the Nodoshop version of the Opentherm Gateway (OTGW)
MIT License
145 stars 34 forks source link

separation of values from thermostat and boiler #143

Open antst opened 1 year ago

antst commented 1 year ago

I kind of understand that currently MQTT is made to be as compatible as it possible with otmonitor. But, as result, it has the same fundamental issue as otmonitor has (and issue which home assistant integration does not have).

There is no separation for values coming from boiler and thermostat.

For example, there is boiler setpoint control. There are two values coming, one from thermostat (what it wants this set point to be) and one from boiler (what is actual setpoint on boiler). If you override this set point (via topic ctrlsetpt), then, effectively, you have two different values, for one topic (TSet). Proper way is to separate values coming from thermostat and from boiler to different topics.

emkookmer commented 1 year ago

I'm encountering similar problems, also i haven't found a way to detect who is in control (ie. The thermostat of otgw) separating these values as Antst is suggesting wil help with this

rvdbreemen commented 1 year ago

@emkookmer if you override the Tset value, the thermostat is no longer in control. It's being overridden by the Gateway. Could you share some logs @antst and @emkookmer to show me what you mean.

Btw what we can do is detect who is controlling the boiler, the gateway or the thermostat. That one is quite easy to add in a future release. Let's do some discussion. If you have joined the Discord community you can talk to me and Schelte on this topic.

rvdbreemen commented 1 year ago

Love to keep improving the project, so feedback is a must.

antst commented 8 months ago

Oh, missed that. Look, effectively we have 2 Tset values. One which is calculated by thermostat, and one which is used by boiler. Once we override Tset, then, effectively, we have 2 Tset values, one which is reported by thermostat, and one which is currently used and reported by boiler. And they are different. Actually, otmonitor has the same issue. (which it didn't have 4 years ago, BTW)

So, either we split them into two reporting values, or we ignore one of them. I am in favor of reporting both. You can say "lets report only actually used by boiler value", but still having access to what thermostat "thinks" is not bad idea, if you ask me. Today I will make logs.

hvxl commented 8 months ago

Actually, otmonitor has the same issue. (which it didn't have 4 years ago, BTW)

@antst You have reported this multiple times in bug reports against otmonitor as well, but then never respond to questions for more details. I have tested your claims and cannot reproduce them. So please stop spreading rumors about alleged bugs in otmonitor unless you can actually show some evidence.

rvdbreemen commented 8 months ago

@antst please share logs to show what you mean. It is important to capture the message from port 24 on the ESP. Make sure the OTmessage logging is turned on.

You may want to turn on the MQTT logging too that way we can see what you mean.

Like I said before I think there is only one true value for Tset.

But I love to see if we can have logs to show what you mean.

Kinds regards Robert