search

rvdbreemen / OTGW-firmware

A ESP8266 devkit firmware for the Nodoshop version of the Opentherm Gateway (OTGW)
MIT License
147 stars 34 forks source link

Fix unit types #51

Closed sjorsjuhmaniac closed 3 years ago

sjorsjuhmaniac commented 3 years ago

Fix unit types for s16-type-tags.

bug reported by @sergeabtd on Discord.

rvdbreemen commented 3 years ago

@sjorsjuhmaniac if we follow the specification 2.2, then you are right about Tsolarcollector (msgid = 30). It should not be a f8.8, but a s16.

However I don't agree with deviding s16 / 256 by default, that's not what the spec says. I think it's an implementation mistake by the vendor of the specific boiler that reports values above 256.

So I will remove the edits to mqttha.cfg, agree?

sjorsjuhmaniac commented 3 years ago

LGTM