search

rvdbreemen / OTGW-firmware

A ESP8266 devkit firmware for the Nodoshop version of the Opentherm Gateway (OTGW)
MIT License
145 stars 34 forks source link

Day number off by 1 #99

Closed arjanwaard closed 2 years ago

arjanwaard commented 2 years ago

If NTP sync is enabled the day number used in the SC command is off by 1.

rvdbreemen commented 2 years ago

That's a good catch, I did notice the spec of OT was different of day of week of iso8601. Simply forgot about it, oops.

Fixed in the dev, just now. Thanks!

rvdbreemen commented 2 years ago

@arjanwaard would you like to validate my fix?

arjanwaard commented 2 years ago

Sure!

On Sat, Dec 25, 2021, 12:43 Robert van den Breemen @.***> wrote:

@arjanwaard https://github.com/arjanwaard would you like to validate my fix?

— Reply to this email directly, view it on GitHub https://github.com/rvdbreemen/OTGW-firmware/issues/99#issuecomment-1001007429, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACGSQRYY4VJAY2RB4ADY4JTUSWU5LANCNFSM5KXDFYBA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>