search

rvdleun / onoffice

The open-source Virtual Office, powered by WebVR
https://onoffice.app
GNU General Public License v3.0
119 stars 15 forks source link

Replace home-brewed WebRTC solution with an existing framework/library #7

Closed rvdleun closed 5 years ago

rvdleun commented 5 years ago

Goal

Change the current WebRTC implementation with an existing library

Description

Getting the WebRTC implementation to working was the result of a long Saturday evening. I tried to get it implemented with a number of NPM modules, but none of them really worked out. In the end, I decided to build my own implementation via some tutorials that I found on the Internet.

I am glad to see that it's working now, but I'm not too happy with it. I would rather have a library that is maintained with people who are more experienced about the subject to handle the WebRTC aspects of streaming a screen to the VR Headset.

Deliverables

rvdleun commented 5 years ago

I've done some early work on trying to get multiple displays to work, but ended up with some issues resulting in WebRTC apparently not being able to support multiple video streams. While I think I remember being able to do so originally, I also just ran into issues where I didn't really know what I'd need to do to adapt the WebRTC code for support.

Did some work on it today, and replaced my WebRTC code with a PeerJS implementation. Pull Request is open at: https://github.com/rvdleun/onoffice/pull/10

rvdleun commented 5 years ago

Merged #10 into the master branch.