rveachkc / pymsteams

Format messages and post to Microsoft Teams.
https://pypi.org/project/pymsteams/
Apache License 2.0
418 stars 77 forks source link

proxy params is changed for httpx #144

Closed ainamori closed 1 year ago

ainamori commented 1 year ago

Describe the bug

Key name for proxy params is wrong.

To Reproduce

Steps to reproduce the behavior:

  1. Create instance with proxy param like this.
        myTeamsMessage = pymsteams.async_connectorcard(
            hookurl="<MS Teams webhook url>",
            http_proxy="http://proxy.example.com:8080",
            https_proxy="http://proxy.example.com:8080",
        )
  1. run this programs.
  2. it appears the following logs like this.
ValueError: Proxy keys should use proper URL forms rather than plain scheme strings. Instead of "http", use "http://"

rveachkc commented 1 year ago

Thanks for looking into this, and closing out