rveciana / obsidian-cooklang

MIT License
8 stars 0 forks source link

Comments aren't recognised or formatted #3

Closed lyndaljane closed 2 months ago

lyndaljane commented 2 months ago

First: thank you for picking this up! The original was good but it's broken now, so glad there's an alternative.

I did notice that comments formatted to Cooklang specs are either hidden in reading mode, or are parsed as cooking steps.

Comments added with "--" between the instruction and the comment, or block comments on a single line with "[-" and "-]" at the start and end are not visible in Reading view.

Block comments split over multi lines display in Reading mode with the first line appended to the end of the last Step, and subsequent lines are parsed as Steps too. In my file I had a single-line block comment between Step 8 and a multi-line block comment; the Reading mode dropped the single-line block comment and chucked the first line of the multi-line at the end of Step 8.

Usages for comments are Descriptions, or Cooking Notes that aren't part of the general recipe method flow (like, "If you use fridge cold eggs, you will notice the batter is thicker. It will still work just fine, but room temperature eggs is better – it makes the batter pourable into the pan. Cake may also need an extra 5 minutes in the oven.").

rveciana commented 2 months ago

Thanks for the issue! I'll try to reproduce it first and then fix it. It seems a parser problem, but let me check.

rveciana commented 2 months ago

As you can see, it's the parser that doesn't interpret the multiline comments properly. I'll try to do a PR there, although I see that the last commit was 9 months ago...

imatge

rveciana commented 2 months ago

OK, so the PR is here: https://github.com/cooklang/cooklang-ts/pull/25 When it's accepted, I'll update the version I'm using so it works. I hope it's accepted some time soon...

rveciana commented 2 months ago

Done! You can try version 0.0.12 now