search

rveen / ogdl-c

OGDL for C
http://ogdl.org
Other
17 stars 5 forks source link

Python - WIP #4

Closed asmodehn closed 7 years ago

asmodehn commented 7 years ago

Issue Ref : https://github.com/rveen/ogdl-c/issues/3 This is still a work in progress, but I open this PR for easy access and feedback.

Status :

I still need to find a better way to package and distribute for python, likely using https://bitbucket.org/renficiaud/cmake-pip/overview, but this package hasn't been released yet...

rveen commented 7 years ago

I have restored the Makefiles, I don't want to loose plain make support. The Readme still to be adapted to both build methods. Do these "old" Makefiles affect the CMake build ?

asmodehn commented 7 years ago

You dont really need them anymore, cmake will generate them (and more) for you, depending the platform and configuration you want. That being said, CMake encourages "out-of-source" builds, which means the existing makefiles, if you chose to keep them, should not impact anything related to the cmake generated build.

Ultimately, you should probably get used to CMake to find out how to integrate it with your existing build toolchain. Let me know if you have any question about it.

I ll do some more PR when I find out how to improve the python packaging...

-- AlexV

On Sat, Sep 30, 2017 at 6:24 PM, Rolf Veen notifications@github.com wrote:

I have restored the Makefiles, I don't want to loose plain make support. The Readme still to be adapted to both build methods. Do these "old" Makefiles affect the CMake buid ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rveen/ogdl-c/pull/4#issuecomment-333296368, or mute the thread https://github.com/notifications/unsubscribe-auth/AANgSHSs3E18rBxPUlnEDKGenHbmQ6BPks5sngjigaJpZM4PpcBp .