search

rvelthuis / DelphiBigNumbers

BigInteger and BigDecimal for Delphi
http://rvelthuis.de/programs/bigintegers.html
BSD 2-Clause "Simplified" License
119 stars 62 forks source link

Reintroduce BigInteger.AsExtended()==.AsDouble() for hasn't-Extended platform #18

Closed KoRiF closed 3 years ago

KoRiF commented 3 years ago

Reintroduce BigInteger.AsExtended()==.AsDouble() for Win64 (SizeOf(Extended) == SizeOf(Double))

TommiPrami commented 3 years ago

Problem here, if I remember correctly, sorry if not, that author of this library is passed a way.

It would need new maintainer. For what I have used it for, it has worked perfectly. Been very thankful of it.

KoRiF commented 3 years ago

remember correctly, sorry if not, that author of this library is passed a way.

Sorry to hear this. He did a great work for the Pascal Community

It would need new maintainer. For what I have used it for, it has worked perfectly. Been very thankful of it.

Problem happens when other project that use BigInteger.AsExtended() call from this library on win32 platform tries to migrate to the win64 then it receives compile time error (BigInteger.AsExtended() becames unavailable due to conditional cmpilation)

Ok, you can close this Pull Request. I could just share this fix in my own branch and the person who wants migrate -->win64 could use my repo or do this fix manually

I don't know what is the most right way how to inform users of this library what the fix they should to do