rveltz / LSODA.jl

A julia interface to the LSODA solver
Other
11 stars 13 forks source link

Add checking of keywords to make solve more robust, fix #166 #30

Closed ScottPJones closed 7 years ago

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.3%) to 86.567% when pulling 41906cc50e95abf251c7a457d8ee7635f0dd639d on ScottPJones:spj/fix166 into 3f0465b303436ec699d6efab7fac08f38462921f on rveltz:master.

codecov-io commented 7 years ago

Codecov Report

Merging #30 into master will increase coverage by 0.13%. The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   86.29%   86.43%   +0.13%     
==========================================
  Files           4        4              
  Lines         197      199       +2     
==========================================
+ Hits          170      172       +2     
  Misses         27       27
Impacted Files Coverage Δ
src/LSODA.jl 100% <100%> (ø) :arrow_up:
src/common.jl 88.07% <66.66%> (+0.11%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3f0465b...f5a4138. Read the comment docs.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.1%) to 86.432% when pulling 24b1aeea3875f2ddf05867da790de20bc0c2e4bd on ScottPJones:spj/fix166 into 3f0465b303436ec699d6efab7fac08f38462921f on rveltz:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.1%) to 86.432% when pulling 24b1aeea3875f2ddf05867da790de20bc0c2e4bd on ScottPJones:spj/fix166 into 3f0465b303436ec699d6efab7fac08f38462921f on rveltz:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.1%) to 86.432% when pulling 24b1aeea3875f2ddf05867da790de20bc0c2e4bd on ScottPJones:spj/fix166 into 3f0465b303436ec699d6efab7fac08f38462921f on rveltz:master.

ChrisRackauckas commented 7 years ago

Nice work. Note @rveltz that this actually requires a DiffEqBase tag, but it's already to merge earlier since instead of throwing a warning on an ignored keyword argument, pre-tag it will throw an error. We chose to go with warnings because technically the solution is still correct, but the user should know that some of what they think might be tweaked isn't actually tweaked. This is a clean solution that handles all of the keyword args.

ScottPJones commented 7 years ago

OK, dtmin/dtmax added

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.1%) to 86.432% when pulling f5a4138592c4848b5aa2a8af960bf1e9ea25ac49 on ScottPJones:spj/fix166 into 3f0465b303436ec699d6efab7fac08f38462921f on rveltz:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.1%) to 86.432% when pulling f5a4138592c4848b5aa2a8af960bf1e9ea25ac49 on ScottPJones:spj/fix166 into 3f0465b303436ec699d6efab7fac08f38462921f on rveltz:master.