Closed ScottPJones closed 7 years ago
Merging #30 into master will increase coverage by
0.13%
. The diff coverage is69.23%
.
@@ Coverage Diff @@
## master #30 +/- ##
==========================================
+ Coverage 86.29% 86.43% +0.13%
==========================================
Files 4 4
Lines 197 199 +2
==========================================
+ Hits 170 172 +2
Misses 27 27
Impacted Files | Coverage Δ | |
---|---|---|
src/LSODA.jl | 100% <100%> (ø) |
:arrow_up: |
src/common.jl | 88.07% <66.66%> (+0.11%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3f0465b...f5a4138. Read the comment docs.
Nice work. Note @rveltz that this actually requires a DiffEqBase tag, but it's already to merge earlier since instead of throwing a warning on an ignored keyword argument, pre-tag it will throw an error. We chose to go with warnings because technically the solution is still correct, but the user should know that some of what they think might be tweaked isn't actually tweaked. This is a clean solution that handles all of the keyword args.
OK, dtmin/dtmax added
Coverage increased (+0.3%) to 86.567% when pulling 41906cc50e95abf251c7a457d8ee7635f0dd639d on ScottPJones:spj/fix166 into 3f0465b303436ec699d6efab7fac08f38462921f on rveltz:master.