Keyboard Navigation in Coffee Script - Credit to @lowegreg

rvera / image-picker

Image Picker is a simple jQuery plugin that transforms a select element into a more user friendly graphical interface.

http://rvera.github.com/image-picker

Other

907 stars 216 forks source link

Closed Humni closed 5 years ago

Humni commented 6 years ago

Credit to @lowegreg for the original js changes

Humni commented 6 years ago

Updated based on changes made to #109 - This version is untested and will need testing before merging

rvera commented 6 years ago

Left a couple of comments, otherwise lgtm!

lowegreg commented 6 years ago

Hold on guys, didn't realize that @Humni converted an older commit to coffee script. The last commit I made was 0a11fbc. sorry for the confusion...

Humni commented 6 years ago

@lowegreg I have updated this pull request based on those 3 extra commits you made since my original pull request. See 3339151 commit message

lowegreg commented 6 years ago

Just checking back to see how this repo is going. Did I forget to do something in order to have these requests merged???

Humni commented 5 years ago

@lowegreg I finally have push access, I'll update the pull request and let you know if it passes testing again

Humni commented 5 years ago

Testing passed: