Closed przmv closed 3 years ago
I'm wondering about the decision of not following redirects with http.Client within fetchHost function: https://github.com/rverton/webanalyze/blob/master/webanalyze.go#L105
http.Client
fetchHost
Following HTTP redirects is crucial for our use case.
What do you think about adding the ability to provide some custom http.Client to NewWebAnalyzer?
NewWebAnalyzer
I'm going to submit a pull request to better describe the idea.
Hi @pshevtsov, following redirects often led to leaving the target scope/environment.
I'm open to make this more configurable if you need it.
Greetings
@rverton PTAL #37
I'm wondering about the decision of not following redirects with
http.Client
withinfetchHost
function: https://github.com/rverton/webanalyze/blob/master/webanalyze.go#L105Following HTTP redirects is crucial for our use case.
What do you think about adding the ability to provide some custom
http.Client
toNewWebAnalyzer
?I'm going to submit a pull request to better describe the idea.