Closed jfallows closed 3 years ago
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
airline-core/src/main/java/com/github/rvesse/airline/restrictions/common/PortRangeImpl.java | 1 | 68.97% | ||
<!-- | Total: | 1 | --> |
Totals | |
---|---|
Change from base Build 535: | 0.01% |
Covered Lines: | 5565 |
Relevant Lines: | 7771 |
Thanks for the contribution, I remain pretty ignorant of JPMS so thanks for digging into this and resolving it π
@rvesse when do you think you would be able to roll a 2.8.1
release with these changes please?
@jfallows Probably next week, busy with security scramble at $dayjob for the sudo
CVE atm
@jfallows Just worked through the release this morning, may take a few hours before the artifacts are visible on Maven central
@rvesse thanks, I just updated the dependency to 2.8.1
and it is working out great! π
When building modular components based on
airline
, the following message is displayed during compilation.This is caused by the
javax.inject
dependency which is missing theAutomatic-Module-Name
entry from the JAR manifest, so the module name is derived from the JAR filename instead. Although the JAR filename is not expected to change for thejavax.inject
dependency, a JAR filename is not considered sufficiently stable to derive a module name in the general case, triggering the compilation warning above.As explained by the Transition from Java EE to Jakarta EE blog post, the
javax
namespace is migrating tojakarta
going forward, so this is a good first step towards fully modularjakarta
based dependencies forjavax.inject
.This pull request addresses the issue by changing the dependency to use an alternative dependency that delivers an automatic module for
javax.inject
package instead.