search

rvi / ONVIFCamera

Pod and example on how to connect to an ONVIF camera
MIT License
88 stars 18 forks source link

API Callback not fired when response data is incorrect #2

Closed mohamed-arradi closed 6 years ago

mohamed-arradi commented 6 years ago

Bug Fixes When calling the GetServices API or any of the others, due to the Guard / Let condition , if data were incorrect, there as only one return.

However the user who try to implement the SDK will face to an issue : No callback will be fired to him.

Description

I added the default callback on every guard for the basic service Then I added an error parameters for some service in order to the developer to be able to display an meaningful message to the user.

Motivation and Context

It fix an issue discovered while trying to build an App for the ONVIF Challenge.

How Has This Been Tested?

Just by calling the services and making sure that a callback is called everytime !

Screenshots (if appropriate):

None

rvi commented 6 years ago

@mohamed-arradi Just sent you a PR: https://github.com/mohamed-arradi/ONVIFCamera/pull/1

mohamed-arradi commented 6 years ago

@rvi the PR is now merged ! Thanks !

rvi commented 6 years ago

Thanks Mohamed for your help!!