search

rvinluan / slack-pokemon

A bot for having Pokemon battles in Slack.
341 stars 46 forks source link

Heroku button isn't an actual "click to deploy" button #7

Open michaeljhopkins opened 9 years ago

michaeljhopkins commented 9 years ago

The current heroku button just takes you to the standard /deploy page at heroku. I'm not super familiar with the platform so I can't make a PR to fix it, however I can link to a project that has a working "click to deploy". https://github.com/gesteves/trebekbot

brh55 commented 9 years ago

It's actually deceiving because in the raw format it doesn't have a template parameter explicitly declared, but if it's clicked directly from Github (exception of a private repo), the deploy button sends a referer header to Heroku, allowing it to determine the template to be used accordingly. The great thing about this is, if the branch is forked, you can properly test quick deployment in reference to your branch and not the master repo.

For more information, check out: https://devcenter.heroku.com/articles/heroku-button