rvion / CushyStudio

🛋 The AI and Generative Art platform for everyone
https://docs.cushystudio.com/
GNU Affero General Public License v3.0
679 stars 50 forks source link

Dock-Panel Header Overhaul #185

Closed birdddev closed 7 months ago

birdddev commented 8 months ago

I noticed about halfway through this you already had a Panel_HeaderUI, so I can move this to there if these seem like good changes to you. While attempting to keep the functionality of what's there already. (I disagree with the option button being on every single header though, they should add that themselves if they need.)

This adds a \<HeaderUI> and a \<SeparatorUI> component, (Put in widgets because I'm not sure where I should be putting it) You can see it being used in this PR in the Import Tab.

HeaderUI

SeparatorUI

Misc. Changes

rvion commented 7 months ago

@birdddev should I merge this one ? it's marked as draft

birdddev commented 7 months ago

I was going to move in to/replace Panel_HeaderUI with this if you gave me the go ahead, and then move everything that wasn't using it to use it before marking it ready.

rvion commented 7 months ago

oh x) should have read that better ! I had no strong opinion, cause the header I added was done in a hurry without much heavy thinking. just wanted a place to add stuff, possibly with the tooltip system, to make sure it wouldn't take too much space on small screen.

Honestly, those changes feel pretty safe (no hidden stuff hard to see), I kinda totally trust you on this one. Usually, when you touch something in the UI, it's way better after, so, all green for me ! ❇️

birdddev commented 7 months ago

Okay, I'll work on moving everything to it in a bit, every header for dock-panels should be very consistent afterwards, except the app draft one which needs its own special stuff at the top.

birdddev commented 7 months ago

Let me know if you have any gripes with the FavBar changes.

birdddev commented 7 months ago

Everything should be updated now.