rvion / CushyStudio

🛋 The AI and Generative Art platform for everyone
https://docs.cushystudio.com/
GNU Affero General Public License v3.0
684 stars 48 forks source link

Error in generated types: Reserved type `number` in global.ts #84

Open ricklove opened 11 months ago

ricklove commented 11 months ago

Reserved type number in global.ts:

Type alias name cannot be 'number'. export type number = ComfyNodeOutput<'number'>

image


Nice work though!

rvion commented 11 months ago

Nice catch! You have a custom node that I'm not aware of that use 'number' as output type. could you take a look at you object_info.json and tell me what node is causing this ? It Would help me troubleshoot if I could install the node and work from there to preventing the conflict with native typescript types

ricklove commented 11 months ago

I think it is from https://github.com/flyingshutter/As_ComfyUI_CustomNodes:

,    "Number_AS": {
        "input": {
            "required": {
                "value": ["FLOAT",{"default":0,"min":-1.7976931348623157e+308,"max":1.7976931348623157e+308}]
            }
        }
,        "output": ["number"]
,        "output_is_list": [false]
,        "output_name": ["number"]
,        "name": "Number_AS"
,        "display_name": "Number_AS"
,        "description": ""
,        "category": "ASNodes"
,        "output_node": false
    }

https://github.com/flyingshutter/As_ComfyUI_CustomNodes/blob/2476d8579206e9aa64f593ac2ae5c88f6fbee252/asnodes.py#L342C7-L342C7