search

rvirding / luerl

Lua in Erlang
Apache License 2.0
1.02k stars 140 forks source link

Add support for GitHub Actions #151

Closed doomspork closed 8 months ago

doomspork commented 1 year ago

Howdy @rvirding 👋 First and foremost, thanks for everything you do 🙏 We talked briefly in Slack about luerl and since those conversations I've been leveraging this library to empower a number of production systems so it's high time I start giving back.

I was looking through the issues and PRs on the repo and noticed #89 which is now many years old. With the availability of GitHub Actions I think it might make more sense to go that route than TravisCI — are you open to that? This PR introduces a single action for running tests. Happy to expand on this with your guidance.

One call out I did want to make: It seems there is a failing test on develop currently but when this change is ported to the master branch we can verify this action runs and tests all pass (here's an example PR on my fork: https://github.com/doomspork/luerl/pull/2).

Please let me know if there's any additional changes you'd like to make. Happy to incorporate any changes that would make this more useful to yourself and other contributors.

doomspork commented 8 months ago

Thanks for the merge @rvirding! 🎉

rvirding commented 5 months ago

A bit late but I think we should expand the matrix to cover more versions of OTP and rebar3. This I will do.

doomspork commented 5 months ago

@rvirding happy to help! If you want to let me know your thoughts on the matrix I'll get a PR up