rviscomi / trunk8

jQuery Truncation Plugin -- THIS PROJECT IS NO LONGER MAINTAINED
MIT License
703 stars 95 forks source link

use jquery.actual to compute height of target element #65

Open styson opened 9 years ago

styson commented 9 years ago

I added a dependency on jquery.actual plugin, and use it to compute height of target, even if not displayed.

The height of a hidden element is 0, but with the plugin the actual height can be detected.

rviscomi commented 9 years ago

Not sure I like the idea of adding a plugin dependency. Is there any logic from jquery.actual that can be inlined in trunk8.js?

styson commented 9 years ago

I'm sure it could be replicated - there was not a huge amount of code.

marijngiesen commented 8 years ago

Check my pull request (#68) for this. I've added some logic from jQuery.actual to make trunk8 work on hidden elements.