search

rviscomi / trunk8

jQuery Truncation Plugin -- THIS PROJECT IS NO LONGER MAINTAINED
MIT License
703 stars 95 forks source link

Add support for working with rendered content to remove the page 'jumps' after truncation #68

Closed marijngiesen closed 6 years ago

marijngiesen commented 8 years ago

This adds support for truncation in hidden elements, so that truncation doesn't cause page 'jumps'. After truncating the hidden element, the element will be cloned and the original rendered content will be overwritten. See README.md for a short explanation.

rviscomi commented 8 years ago

Thanks.

It's impossible to check the diff of the js file because it seems you've changed the spacing of the file (tabs/spaces). Can you fix that?

marijngiesen commented 8 years ago

Oh, haha yeah I see. My IDE found it was necessary to do that. I'll look into it.

marijngiesen commented 8 years ago

Still not great, but better readable. I hope you can see the changes I've made now. I'll fix the indentation more after you've reviewed it.

marijngiesen commented 8 years ago

Any thoughts?

rviscomi commented 8 years ago

Sorry, it's still too difficult to read as-is. I'd really only like to see a diff of your changes.

marijngiesen commented 8 years ago

Ok, the formatting should be the way it was. You do use some strange indenting rules by the way..

nilbus commented 6 years ago

I agree with the goal of this patch, but I think it requires the user to do too much, creating elements with specific CSS properties. It just feels fragile.

marijngiesen commented 6 years ago

Ok, no problem. I'm not using the lib anymore, so I'll just close this.