rvlenth / emmeans

Estimated marginal means
https://rvlenth.github.io/emmeans/
358 stars 31 forks source link

Partial argument patch of `just` to `justify` #463

Closed pawelru closed 8 months ago

pawelru commented 8 months ago

This occurred when calling print() on "emmGrid" class of object but the root cause is there: https://github.com/rvlenth/emmeans/blob/b04aa6e936e0496448727c1d193824bbeb4ae667/R/summary.R#L1318

I assume reprex is not needed here.

rvlenth commented 8 months ago

I removed the "bug" label because the argument is always correctly matched so it causes no errors.

rvlenth commented 8 months ago

... and if you think this did cause an error, then yes, a reprex is required.

pawelru commented 8 months ago

The longer story is that I am testing my code against some potential errors due to partial argument match:

list(
  warnPartialMatchDollar = TRUE,
  warnPartialMatchArgs = TRUE,
  warnPartialMatchAttr = TRUE,
  warn = 2
)

This however tests the whole stack of calls (i.e. not only my code but also packages that I depend on - both directly and indirectly). I am aware that this is rather an unusual setup but it's done on purpose. Now I am sharing my discoveries with respective pkg authors.