search

rvm / executable-hooks

Other
21 stars 12 forks source link

Doesn't work with thin cluster... #13

Closed acatighera closed 10 years ago

acatighera commented 10 years ago

If you run thin start -s3 you will get ruby not found error. This is due to the fact that the Command.script var gets set to "ruby /path/to/thin" instead of "/path/to/thin". This value comes from $PROGRAM_NAME.

mpapis commented 10 years ago

what ruby version and executable-hooks version are you using?

acatighera commented 10 years ago

ruby 2.0.0p247

I believe I had 1.2.1 installed, I had to remove it to get thin running.

mpapis commented 10 years ago

can you test again with 1.3.1? similar issues #5, #7, #8.

those lines are relevant: https://github.com/mpapis/executable-hooks/blob/master/bin/ruby_executable_hooks#L4-L5

can you find a place in thin that would conflict with it if you still get problems in 1.3.1?

acatighera commented 10 years ago

It was happening in prod so I can't retest easily.

The command is getting generated here: https://github.com/macournoyer/thin/blob/master/lib/thin/command.rb#L50 self.class.script comes from $PROGRAM_NAME which is pulled from shebang in bin file I believe.

mpapis commented 10 years ago

I assume this is the same thing that was already fixed in #8 - closing the issue, please feel free to provide any more details if you can reproduce it with latest version and I will reopen and continue investigation.