search

rvm / executable-hooks

Other
21 stars 12 forks source link

end_with? is not Ruby 1.8.6 compatible #36

Closed msjonker closed 3 years ago

msjonker commented 5 years ago

https://github.com/rvm/executable-hooks/blob/master/bin/ruby_executable_hooks#L13 uses end_with? on a String, however that was added in 1.8.7 and causes 1.8.6 to error with messages such as:

/usr/local/rvm/rubies/default/bin//ruby_executable_hooks:13: undefined method `end_with?' for "/usr/local/rvm/rubies/default/bin/rake":String (NoMethodError)

mpapis commented 5 years ago

Thank you for the report, could you open a PR with https://ruby-doc.org/core-1.8.6/String.html#method-i-match

msjonker commented 5 years ago

Sure, will do.