search

rvm / gem-wrappers

Create gem wrappers for easy use of gems in cron and other system locations.
Other
14 stars 4 forks source link

Avoid nested chdir warnings #11

Closed skaes closed 6 years ago

skaes commented 6 years ago

After running rvm get latest, I get a lot of warnings when running bundle install:

/Users/stefan.kaes/.rvm/gems/ruby-2.4.1-railsexpress@global/gems/gem-wrappers-1.3.1/lib/gem-wrappers.rb:46: warning: conflicting chdir during another chdir block

I tracked this down to a change in for the 1.3.1 version of this gem.

This patch fixes the problem by avoiding the use of chdir.

Also, the old code had a subtle bug: directories are usually executable to, so one should exclude them from the list of binaries.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.02%) to 98.256% when pulling e1eddf618d655b295bcfe92408ea54acf2efeaed on skaes:avoid-nested-chdir-warnings into b8ac15602857a8e384055d87c2d42575b52eed2a on rvm:master.