search

rvm / rvm1-ansible

The official ansible RVM role to install and manage your Ruby versions.
MIT License
271 stars 136 forks source link

Specify bundler install version #201

Closed colemanja91 closed 4 years ago

colemanja91 commented 5 years ago

Bundler 2 is not backwards compatible with Bundler 1, so we need to specify a version. This keeps the default at the current version (2.0.1), but provides a variable for the user to configure.

pkuczynski commented 4 years ago

@colemanja91 as @swanandp suggested this needs to be fixed with -v. Would you mind improving your PR, so we can merge it in?

pkuczynski commented 4 years ago

Seems that this is a duplicate of #191?

pkuczynski commented 4 years ago

@Kulgar which one you think is better #191 or #201?

pkuczynski commented 4 years ago

on a similar PR #48 @lpaulmp mentioned:

@DavidHuie Please can rebase this PR and make sure that it installs the last bundler by default?

thbar commented 4 years ago

@colemanja91 thanks for the PR!

For now, we will close this one, because after experimenting a bit more, we want to cover more flexibility.

You can add your feedback to #217 which we'll use as a basis to design a more complete solution.

Thank you anyway for your PR, which has helped the project move forward!