search

rvm / rvm1-ansible

The official ansible RVM role to install and manage your Ruby versions.
MIT License
271 stars 136 forks source link

Travis CI: Verify that "Ansible --check mode" passes #220

Open gildegoma opened 4 years ago

gildegoma commented 4 years ago

Initially motivated by #218.

In order to get a build success, this PR (temporarily) includes the changes proposed in #219.

pkuczynski commented 4 years ago

Does not seem to help. The build is still failing :(

gildegoma commented 4 years ago

The CI job detected a new problem, occurring only with the root.yml playbook.

See https://travis-ci.org/github/rvm/rvm1-ansible/jobs/714023964#L296 for instance.

thbar commented 4 years ago

We have updated & tested #219. I believe it will be good to first merge #219, then update #220!

gildegoma commented 4 years ago

Rebased and now ready for review.

gildegoma commented 4 years ago

Would you mind adding a comment in the code here too to explain running check mode twice? I think that would be helpful for someone looking at the code for the first time without reading our PR comments.

@danochoa thank you for all the feebacks 😃. Yes, if we stick the goal to support "check mode" in any situation, I'll add a comment to try to make things crystal clear.

pkuczynski commented 2 years ago

As we are moving away from Travis to GHA, is this still valid @danochoa ?

thbar commented 2 years ago

See #235, which maybe will have to be merged first, to see if current PR is worth adapting to GH actions.

pkuczynski commented 2 years ago

@gildegoma as we migrated to Github Actions in #235, is this still somehow valid, and would you like to migrate this to the new CI?

thbar commented 2 years ago

Related: https://github.com/rvm/rvm1-ansible/issues/226

pkuczynski commented 2 years ago

Ping @gildegoma...