search

rvm / rvm1-ansible

The official ansible RVM role to install and manage your Ruby versions.
MIT License
271 stars 136 forks source link

Fix RHEL 7 & 8 based distros to work around /tmp execution issues #230

Closed stevenhaddox closed 2 years ago

stevenhaddox commented 2 years ago

Implements the suggested fix from #155 in order to enable rvm to install properly on CentOS 8 (and hopefully 7 and a few other distro variations as well).

Fixes #155

stevenhaddox commented 2 years ago

Shout out to @coofercat for the suggested fix.

nartz commented 2 years ago

I could use this as well - thanks!

stevenhaddox commented 2 years ago

Thought I'd follow-up on this to see if it might be able to be merged (I came across my #TODO in my galaxy file preventing me from being able to enable the galaxy collection for rvm until this is merged in).
cc @danochoa, maybe?

stevenhaddox commented 2 years ago

@sfgeorge @danochoa - pushed up the requested change. Let me know if you need anything else and thanks for your time.

sfgeorge commented 2 years ago

@stevenhaddox Fantastic, thank you for the quick change. I'm terribly sorry to ping-pong with another request, but could you add a brief entry in CHANGELOG.md? Just a bullet would about fixing installation error in CentOS 7&8 would do.

stevenhaddox commented 2 years ago

@sfgeorge no need to apologize. Thanks for your patience. Hopefully that last push is what you're looking for 🤞🏻

sfgeorge commented 2 years ago

I shall bother you no more, this hungry commit-monster is finally satiated!

Thank you for the great fix, @stevenhaddox !

sfgeorge commented 2 years ago

Oops, I don't have ability to move this forward. @danochoa Can you merge if you deem it ready?

danochoa commented 2 years ago

It looks like the old CI server is no longer working. Maybe @pkuczynski can help? I think I don't have access to fix this but I can poke around a bit later. https://travis-ci.org/github/rvm/rvm1-ansible/requests

sfgeorge commented 2 years ago

@danochoa I noticed the same and tracking as #233.

tl;dr With new pricing changes, it's possible but semi-painful to get a renewal of some Travis-CI build hours going. Alternatively, we can move to GitHub Actions.

pkuczynski commented 2 years ago

Thanks!