search

rvm / rvm1-ansible

The official ansible RVM role to install and manage your Ruby versions.
MIT License
271 stars 136 forks source link

Improve Bundler setup to support RVM aliases #52

Open gildegoma opened 9 years ago

gildegoma commented 9 years ago

Without this change, the Bundler setup fails when the rvm_rubies list contains valid RVM aliases, like following examples:

These aliases are quite useful to refer to the latest release of a specific Ruby branch.

gildegoma commented 9 years ago

Just noticed that this PR will conflict with #48. No problem for me to integrate this change as well, or rebase if necessary.

lpaulmp commented 7 years ago

@gildegoma Sorry for the late reply but are you thinking to rebase this PR

pkuczynski commented 4 years ago

@gildegoma would you mind rebasing this PR?

gildegoma commented 4 years ago

@pkuczynski Sure, I'll do. (Sorry to have missed the previous call, but I wasn't using this role for quite a while...).

pkuczynski commented 4 years ago

No worries. Thanks for looking into it now :) Let me know when it's ready for the review...

gildegoma commented 4 years ago

FYI: @pkuczynski I am waiting for #215 (which fixes the Travis CI setup, and extend the tests so it will be convenient to cover the change proposed here).

pkuczynski commented 2 years ago

@gildegoma seems that this has conflicts. Can you solve them?

thbar commented 2 years ago

@pkuczynski this seems to conflict with #235, maybe we should prioritise review/merge of #235 so that the rest can be adapted?

pkuczynski commented 2 years ago

235 is merged... @gildegoma can you rebase?