search

rvm / rvm1-ansible

The official ansible RVM role to install and manage your Ruby versions.
MIT License
271 stars 136 forks source link

Add option to disable binary symlink #94

Closed nathantypanski closed 2 years ago

nathantypanski commented 8 years ago

Symlinks are already disabled for user installs. For cases where multiple system-wide Ruby versions are provided by RVM, add an option to disable symlinking of binaries to the system path.

Default rvm1_symlink to true to maintain existing behavior parity.

lpaulmp commented 7 years ago

Can rebase this PR?

pkuczynski commented 4 years ago

@nathantypanski could you please solve conflicts? Otherwise, we will have to close this PR :(

nathantypanski commented 4 years ago

@pkuczynski sure, looking into it now.

nathantypanski commented 4 years ago

@pkuczynski updated by rebasing against master. Looks like builds are failing on the latest master - but that seems unrelated?

pkuczynski commented 4 years ago

@thbar what you think?

thbar commented 4 years ago

@pkuczynski I have no familiarity with this option at all (I also do not use root installation). I will have a closer look next week, but if someone is more familiar with that, another pair of eyes is welcome!

pkuczynski commented 2 years ago

@sfgeorge @danochoa @thbar what do you think about this change?

thbar commented 2 years ago

This sounds reasonable. Reading the code I wondered a bit of the precedence of operators (not, and, in), but that's pretty much it!