search

rvmiller89 / multitype

Eclipse Plug-in for collaborative code editing similar to Google Docs
0 stars 0 forks source link

Receiving FEUs after a Close_Client_File #26

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Non-host closes a shared file
2. Host types something
3. Non-host receives a markup feu

What is the expected output? What do you see instead?
Expected: Should not be received by FEUListener
Getting: It's being received which is causing a NullPointerException on our part

Please use labels and text to provide additional information.

Sent: FEU: NF | Type: Close_Client_File | 

Received: FEU: MU | FID: 1 | UID: 1 | RVN: 4 | FEUID: 0 | Type: Ins | LOC: 0 | 
STR: a

GetUpdate: FEU: MU | FID: 1 | UID: 1 | RVN: 4 | FEUID: 0 | Type: Ins | LOC: 0 | 
STR: a
Exception in thread "Thread-3" java.lang.NullPointerException
    at multitype.editors.EditorManager.receive(EditorManager.java:379)
    at multitype.FEUManager.dispatchFEU(FEUManager.java:37)
    at multitype.FEUListener$1.run(FEUListener.java:32)
    at java.lang.Thread.run(Thread.java:662)

Original issue reported on code.google.com by rvmille...@gmail.com on 14 Apr 2011 at 3:03

GoogleCodeExporter commented 9 years ago

Original comment by rvmille...@gmail.com on 14 Apr 2011 at 3:04

GoogleCodeExporter commented 9 years ago 
Server is getting the Close_Client_File feu

Original comment by rvmille...@gmail.com on 14 Apr 2011 at 3:04

GoogleCodeExporter commented 9 years ago 
please add server output

Original comment by rharagut...@gmail.com on 14 Apr 2011 at 3:08

GoogleCodeExporter commented 9 years ago 
the fileusermanager code looks good to me, but it is all being done on one 
line... Maybe split up that line to get better type checkIng? (on my iPod ATM, 
so I can't change it)

Original comment by wedgepla...@gmail.com on 14 Apr 2011 at 3:28

GoogleCodeExporter commented 9 years ago 
yea, i checked out the server too. I think we'll just have to step through it 
later tonight. 

in the meantime, ryan can you make sure that you guys are passing the correct 
fileid to the backendclient?

Original comment by rharagut...@gmail.com on 14 Apr 2011 at 3:33

GoogleCodeExporter commented 9 years ago 
Server Running.
Accepted Client
Sending: --------------------
Notification FEU:
type: Connection_Succeed
assign id: 0
---------------------
Sent client UID: 0
Client Added
Received: --------------------
Notification FEU:
type: User_Connected
user id: 0
username: RyanPOD
---------------------
Sending 1 users to client 0
Sending: --------------------
Notification FEU:
type: User_Connected
user id: 0
username: RyanPOD
---------------------
Sending: --------------------
Notification FEU:
type: User_Connected
user id: 0
username: RyanPOD
---------------------
Sending: --------------------
Notification FEU:
type: New_Host
---------------------
Accepted Client
Sent client UID: 1
Client Added
Sending: --------------------
Notification FEU:
type: Connection_Succeed
assign id: 1
---------------------
Received: --------------------
Notification FEU:
type: User_Connected
user id: 1
username: Ryan
---------------------Sending 2 users to client 1
Sending: --------------------
Notification FEU:
type: User_Connected
user id: 1
username: Ryan
---------------------

Sending: --------------------
Notification FEU:
type: User_Connected
user id: 1
username: Ryan
---------------------
Sending: --------------------
Notification FEU:
type: User_Connected
user id: 0
username: RyanPOD
---------------------
Sending: --------------------
Notification FEU:
type: User_Connected
user id: 1
username: Ryan
---------------------
Sending: --------------------
Notification FEU:
type: New_Host
---------------------
Received: --------------------
Notification FEU:
type: Request_Host
---------------------
Sending: --------------------
Notification FEU:
type: New_Host
---------------------
Sending: --------------------
Notification FEU:
type: New_Host
---------------------
Received: --------------------
Notification FEU:
type: New_Shared_File
---------------------
Sending: --------------------
Notification FEU:
type: New_Shared_File
---------------------
Sending: --------------------
Notification FEU:
type: New_Shared_File
---------------------
Added a new file. FID: 0
Received: --------------------
Notification FEU:
type: Get_Shared_File
---------------------Sending: --------------------
Notification FEU:
type: Get_Shared_File
---------------------

Received: --------------------
Notification FEU:
type: Send_File
---------------------
Sending: --------------------
Notification FEU:
type: Send_File
---------------------
Received: --------------------
Notification FEU:
type: Close_Client_File
---------------------
Received: --------------------
Markup FEU:
file id: 0
user id: 1
rev: 0
type: Insert
start loc: 0
insert : a
---------------------
Sending: --------------------
Markup FEU:
file id: 0
user id: 1
rev: 1
type: Insert
start loc: 0
insert : a
---------------------

Original comment by rvmille...@gmail.com on 14 Apr 2011 at 3:42

GoogleCodeExporter commented 9 years ago 
Yes, I made sure we are sending the correct fileid

Original comment by rvmille...@gmail.com on 14 Apr 2011 at 3:43

GoogleCodeExporter commented 9 years ago 
Note that the server code above was from a different test (with only one file 
shared).  But we still get a 

GetUpdate: FEU: MU | FID: 0 | UID: 1 | RVN: 1 | FEUID: 0 | Type: Ins | LOC: 0 | 
STR: a
Exception in thread "Thread-3" java.lang.NullPointerException
    at multitype.editors.EditorManager.receive(EditorManager.java:359)
    at multitype.FEUManager.dispatchFEU(FEUManager.java:37)
    at multitype.FEUListener$1.run(FEUListener.java:32)
    at java.lang.Thread.run(Thread.java:662)

Original comment by rvmille...@gmail.com on 14 Apr 2011 at 3:45

GoogleCodeExporter commented 9 years ago 
If you do have any time, try to look into this before the meeting tonight.

We should really just be testing and getting ready for the presentation 
tomorrow at the meeting.

Original comment by rvmille...@gmail.com on 14 Apr 2011 at 3:49

GoogleCodeExporter commented 9 years ago 
I have no time before the meeting. Are you sure you are also sending te correct 
userid?

Original comment by wedgepla...@gmail.com on 14 Apr 2011 at 4:29

GoogleCodeExporter commented 9 years ago 
I'm also short on time, were you using a fresh server in both cases?

Original comment by rharagut...@gmail.com on 14 Apr 2011 at 4:35

GoogleCodeExporter commented 9 years ago 
Rodrigo -- Yes.

John -- Yes.

Sending Close_Client_File with fileid: 0 and filename: Test2.txt from user: 0: 
RyanPOD

GetUpdate: FEU: MU | FID: 0 | UID: 1 | RVN: 1 | FEUID: 0 | Type: Ins | LOC: 0 | 
STR: b
Exception in thread "Thread-3" java.lang.NullPointerException
    at multitype.editors.EditorManager.receive(EditorManager.java:352)
    at multitype.FEUManager.dispatchFEU(FEUManager.java:37)
    at multitype.FEUListener$1.run(FEUListener.java:32)
    at java.lang.Thread.run(Thread.java:662)

**** This error only seems to occur if the non-host connects first, then 
another user connects who becomes host   ****

Original comment by rvmille...@gmail.com on 14 Apr 2011 at 4:52

GoogleCodeExporter commented 9 years ago 
for ref tonight:
debugging through, doing these steps over i noticed fileusermap has a 0 to 0, 
0, 0, 3

Original comment by rharagut...@gmail.com on 14 Apr 2011 at 8:34

GoogleCodeExporter commented 9 years ago 
reconfirmed ryan's suspicion about a non-host having to connect first to 
produce this error

Original comment by rharagut...@gmail.com on 14 Apr 2011 at 8:53

GoogleCodeExporter commented 9 years ago 
Should be fixed

Original comment by wedgepla...@gmail.com on 15 Apr 2011 at 2:50