Closed shlomif closed 11 years ago
rvosa
commented
11 years ago Dear Shlomi,
thank you for bringing this to my attention, unfortunately I am unable to reproduce the behaviour with SVG.pm 2.59. (The test compares the string output of two SVG trees). Do you have any idea what it could be?
Thanks,
Rutger
shlomif
commented
11 years ago Dear Rutger,
thanks for your comment.
With which version of perl did you try? I now tried it with perl-5.16.3 and the tests pass there, but like I said - they still fail with perl-5.18.0 (possibly due to the new, stricter hash randomisation). Can you try it on perl-5.18.0?
Regards,
Shlomi Fish
rvosa
commented
11 years ago I tried on 5.12 - I fear it must be the hash randomization thing, then. Mmmm - the idea of the test was simply to ensure the tree drawer is not needlessly caching things (which it did in an earlier, buggy iteration) but if hash keys are reordered it should be fine. Gotta change the test to keep with that spirit, even if the exact string match fails.
shlomif
commented
11 years ago @rvosa : ack.
shlomif
commented
11 years ago @rvosa: any news about fixing it?
rvosa
commented
11 years ago I am thinking about just retiring that test: I have removed the caching that this test was supposed to expose anyway so now it's a moot point. Having said that, I've always assumed that hash keys are randomized so it's on the one hand encouraging that only this test fails with the new perl and a heads up to make sure that this is truly the case.
On Saturday, June 22, 2013, Shlomi Fish wrote:
@rvosa https://github.com/rvosa: any news about fixing it?
— Reply to this email directly or view it on GitHubhttps://github.com/rvosa/bio-phylo/issues/13#issuecomment-19858249 .
Dr. Rutger A. Vos Bioinformaticist Naturalis Biodiversity Center Visiting address: Office A109, Einsteinweg 2, 2333 CC, Leiden, the Netherlands Mailing address: Postbus 9517, 2300 RA, Leiden, the Netherlands http://rutgervos.blogspot.com
shlomif
commented
11 years ago @rvosa : any news?
rvosa
commented
11 years ago I have removed the test. I don't really have another choice at this point.
shlomif
commented
11 years ago @rvosa : thanks. Now please upload a new version to CPAN, so I can package it.
Regards,
-- Shlomi Fish
rvosa
commented
11 years ago I have just uploaded v.0.56 to CPAN, so it should be available shortly. Thank you for following up on this.
shlomif
commented
11 years ago @rvosa : thanks! I'll try it soon.
Bio-Phylo-0.55 fails its tests when SVG.pm is installed with perl-5.18.0 from perlbrew on Mageia Linux Cauldron x86-64. Here is the shell session. Please look into fixing it.