search

rvs76 / tvdblib

Automatically exported from code.google.com/p/tvdblib
0 stars 0 forks source link

Invalid season/episode number gives wrong exception and exposes TvDb API key #3

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Call GetEpisode for a valid series id, but a season nr and episode nr
combination that is not valid. 

What is the expected output? What do you see instead?
Should receive an exception to reflect the problem, receive an exception
stating my API key is invalid and prints out my API key.

What version of the product are you using? On what operating system?
tvdblib 0.4.0 on Windows XP

Please provide any additional information below.
Shouldn't the API key be kept relatively secure, if so then could you also
ensure that exceptions never expose the key.

Original issue reported on code.google.com by krisg1...@gmail.com on 15 Sep 2008 at 12:18

GoogleCodeExporter commented 9 years ago 
Thanks, outputting the api key is indeed a bad idea. This is fixed now in the 
latest
svn... If an nonexistent episode is requested, a TvdbContentNotFoundException 
is thrown. 

There will most likely be a new version this week since there is a new feature 
coming
on thetvdb.

Original comment by bgmei...@gmail.com on 15 Sep 2008 at 4:57