search

rvw-org / rvw

R interface to Vowpal Wabbit
22 stars 2 forks source link

Setup PRs? #1

Closed coatless closed 6 years ago

coatless commented 6 years ago

@ivan-pavlov, you're doing a great job on the develop line.

Would it be possible to slowly start to do PRs into the master? I think this would make it easier to do code reviews and have testable nightly builds for us to explore.

ivan-pavlov commented 6 years ago

Yes, sure, thank you!

I still experimenting with External Pointers implementation of VW object, but I will finish that soon. And start using PR for the main version of a package.

eddelbuettel commented 6 years ago

I think we can close this now.