Feature/rework vwtest output

rvw-org / rvw

R interface to Vowpal Wabbit

22 stars 2 forks source link

Closed ivan-pavlov closed 6 years ago

ivan-pavlov commented 6 years ago

So, finally over This PR adds new features:

Possibility to specify parameters directly like in CL version

vwsetup(
params_str = "--random_seed 1 --quadratic bc --learning_rate 0.05 --l1 1E-7 --ect 3"
)

Also:

More tests to get codecov of around 90%
New demo and reworked documentation (types and defaults are specified for all parameters)
Bunch of bug fixes

eddelbuettel commented 6 years ago

I'd say feel free to merge unless you are waiting on @coatless ...

ivan-pavlov commented 6 years ago

@coatless , I would be happy to see your review, but if you are busy right now, then I guess one approval is enough

coatless commented 6 years ago

Hi folks, I was traveling. I'll review this after I finish lecturing for the day ~4pm CDT.