search

rvweeren / lofar_facet_selfcal

Selfcalibration for individual LOFAR sources and facets
7 stars 8 forks source link

findrefant_core leaves hdf5 file open #15

Closed rvweeren closed 1 month ago

rvweeren commented 2 years ago

https://github.com/rvweeren/lofar_facet_selfcal/blob/c2c8c1eea5d2f8104145eb9e61688e39d41e4e2e/facetselfcal.py#L3929

@cgroeneveld For some reason, this function does not close the hdf5 file (maybe the "get" operations cause a cascade of other openings?). Because the hdf5 stays open other steps down the line crash (like h5_merger).

rvweeren commented 2 years ago

Work around is in place, manually closing the file (not the nicest solution but it works, the real issue seems to be losoto that leaves the h5 open...).

rvweeren commented 1 month ago

Turns out this was caused by several missing H.close() (because of an early return out of a function)

rvweeren commented 1 month ago

Fixed in today's update.