Open kevinold opened 10 years ago
I like it!
What else can we put in there? I'm about to go radio silent for 5 hours, but dig through the issues and see what else is good fodder for this and I can land it when I get to Seattle :)
I'll keep thinking on what tripped me up and that we can add to the list.
Another idea I had was to add a "postinstall" message to remind the user to update voodoospark. I've never done it, but I think it'll work:
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1",
"postinstall": "echo \"Make sure you have the latest voodoospark!\""
},
I can send this as another PR if you like the idea.
Kevin
Kevin Old kevin@kevinold.com
On Mon, Jul 28, 2014 at 4:01 PM, Rick Waldron notifications@github.com wrote:
I like it!
What else can we put in there? I'm about to go radio silent for 5 hours, but dig through the issues and see what else is good fodder for this and I can land it when I get to Seattle :)
— Reply to this email directly or view it on GitHub https://github.com/rwaldron/spark-io/pull/34#issuecomment-50400081.
Write a patch!
On Monday, July 28, 2014, Kevin Old notifications@github.com wrote:
I'll keep thinking on what tripped me up and that we can add to the list.
Another idea I had was to add a "postinstall" message to remind the user to update voodoospark. I've never done it, but I think it'll work:
"scripts": { "test": "echo \"Error: no test specified\" && exit 1", "postinstall": "echo \"Make sure you have the latest voodoospark!\"" },
I can send this as another PR if you like the idea.
Kevin
Kevin Old kevin@kevinold.com javascript:_e(%7B%7D,'cvml','kevin@kevinold.com');
On Mon, Jul 28, 2014 at 4:01 PM, Rick Waldron <notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:
I like it!
What else can we put in there? I'm about to go radio silent for 5 hours, but dig through the issues and see what else is good fodder for this and I can land it when I get to Seattle :)
— Reply to this email directly or view it on GitHub https://github.com/rwaldron/spark-io/pull/34#issuecomment-50400081.
— Reply to this email directly or view it on GitHub https://github.com/rwaldron/spark-io/pull/34#issuecomment-50403791.
I have the message working with a "prepublish" or "postinstall" but the placement is the same and it gets printed before the dependencies are installed so it could get lost in the noise. Ideas?
This might be just for me and my recent issue (https://github.com/rwaldron/spark-io/issues/33) but I think this section and reiteration would help others (maybe just me in a few weeks/months).