search

rwcarlsen / goexif

Decode embedded EXIF meta data from image files.
BSD 2-Clause "Simplified" License
627 stars 134 forks source link

JSON marshaling #2

Closed dustin closed 11 years ago

dustin commented 11 years ago

Hey, I wanted to use this in a project and needed a quick way to JSON up the results. This does the trick well enough, though could be improved some with a bit more careful handling of types.

rwcarlsen commented 11 years ago

I'll take a closer look over it and probably merge it tomorrow morningish. Glad to see someone (other than myself) finding use for the package. Any suggestions/feedback on the API, documentation, etc - feel free to create issues for any suggestions you have (I know more tests are needed :-)

dustin commented 11 years ago

Might be good to collapse my 1 and 3 patches. The content that comes out is a bit messy so I just try to extract enough meaning to figure out what it is.

It looks pretty good overall -- quite happy to find it. Getting rid of the panics made it work with my program a lot better :)

The main thing I needed was the JSON encoding. If you're paying more attention to EXIF than I am, you may decide what I did there isn't quite right (I don't know much, I just want as much data as I can get to come out to come out of it).

Thanks a lot for making this exist.