Open mholt opened 7 years ago
Can you link to a sample image that repros the panic?
The docs for Rat
say "It panics for zero deminators or if i is out of range.", so it sounds like the panic is expected, based on a zero denominator in the exif data (though maybe returning an error instead would make it easier to use!)
Hmm, I don't have the sample image anymore, I'd have to dig to find it. Which I could do, but... later.
I really wish it didn't panic. :) Libraries shouldn't panic. It should return an error value.
Totally agree!
FWIW, looking at the open pull requests, it looks like active development on this library has moved to https://github.com/xor-gate/goexif2.
It might be worth checking to see whether that fork has the same bug, and if so re-reporting it there.
I'm commenting on this old issue as i'm the author of goexif2 the fork of rwcarlsen/goexif. This issue is still not resolved but was resolved in goexif2. I have archived goexif2 as both projects are diverged. I would like to see all the patches I did integrated into rwcarlsen/goexif so it could be rock solid.
@rwcarlsen what do you think about merging the patches I did on goexif2 to make it more mature back to goexif?
@rwcarlsen Any thoughts on that? ^
That sounds fine to me. @mholt Would you be willing to take lead? I can add you as a collaborator here. I'm busy trying to build a house in my spare time right now.
@rwcarlsen Thanks for the invitation. I am a bit busy lately myself; but if I can circle back to this I will let you know!
This is a tough time to build a house, best of luck! That's exciting though.
I'm trying to track down how to reproduce this error, but:
So this line must mean that
d
is 0.My calling code: