exif, tiff: Simplify and add comments.

rwcarlsen / goexif

Decode embedded EXIF meta data from image files.

BSD 2-Clause "Simplified" License

627 stars 134 forks source link

exif, tiff: Simplify and add comments. #7

Closed mewmew closed 11 years ago

mewmew commented 11 years ago

Add comment about marker value, EXIF (0xE1 = APP1).
Simplify newAppSec.
Use io.ReadFull where appropriate.
Use bytes.Buffer for Tiff String() method.

rwcarlsen commented 11 years ago

Preferrably in a single commit (via reset + "add -i" or rebase) - so newAppSec doesn't wobble back and forth between two separate commits. Or I can do it if you don't mind "losing credit" for the contribution in the repo history (I could throw your username in the commit message).

mewmew commented 11 years ago

Thank you for spotting the bug I introduced. I've closed this pull request in favor of pull request 10.