search

rwcarlsen / goexif

Decode embedded EXIF meta data from image files.
BSD 2-Clause "Simplified" License
627 stars 134 forks source link

tiff: Make names more consistent with the spec. Note: API change. #9

Closed mewmew closed 11 years ago

mewmew commented 11 years ago

Field names are derived from Section 2, Image File Directory (TIFF spec 6.0) Tag: "Id" seems appropriate even though it deviates from the spec, since name "Tag" is used to represent the struct. Type: Rename "Fmt" to "Type" to make this field consistent with the spec Count: Rename "Ncomp" to "Count" to make this field consistent with the The "output" struct in "tiff_test.go" already uses the name "coun Value/Offset: "Val" is consistent with the spec.

This pull request depends on/includes pull request 8 which fixes a bug in convertVals.

rwcarlsen commented 11 years ago

Seems reasonable enough - especially since the API change is not likely to be part of the API that gets much use.