search

rweng / jquery-datatables-rails

jquery-datatables gem for rails
MIT License
564 stars 338 forks source link

ZeroClipboard.js is not needed any longer #109

Closed luismaia closed 10 years ago

luismaia commented 10 years ago

Hi,

I just use this gem (version 2.1.10.0.2) in rails (version 4.1.0) and I was getting problems (the buttons of the TableTools extension were doing nothing).

It happened because I was adding: //= require dataTables/extras/ZeroClipboard after //= require dataTables/extras/dataTables.tableTools

It looks like that after this commit (https://github.com/DataTables/TableTools/commit/de627aa3d272bf17a939d5463094ade72d5ae0a1#diff-af0ec7aac27919a30348776e1321c59b) is no longer necessary to include ZeroClipboard.js, since it's "duplicated" in the file dataTables.tableTools.js.

For what I understand after TableTools version 2.2.0 (28 Jan 2014) it is only necessary to reference file dataTables.tableTools.js.

Do you agree with ZeroClipboard.js deletion? If so, I can send you a pull request.

Thank you!

ricardodovalle commented 10 years ago

Hi @luismaia, thank you very much. Please, could you fix the README.md too with a note about this change? I am waiting your PR.

Thanks.

luismaia commented 10 years ago

Hi @ricardodovalle, Done. (README.md also updated) You can find my PR on issue https://github.com/rweng/jquery-datatables-rails/pull/110.

Thank you.