search

rwesson / NEAT

Empirical analysis of ionised nebulae, with uncertainty propagation
GNU General Public License v3.0
9 stars 5 forks source link

Weighting scheme for temperatures/densities #32

Closed rwesson closed 8 years ago

rwesson commented 11 years ago

Our hardcoded weighting scheme for calculating the temperature and density in each zone is good in most circumstances but occasionally it might be desirable for the user to change it. We could change the code such that the weighting scheme is read in from a file that the user can edit. We should make sure that the scheme used is recorded in the output for ease of reproducibility.

rwesson commented 11 years ago

We could do the same for the abundance calculations and allow the user to specify which lines are used to calculate final abundances, if the default scheme should for some reason not be appropriate.

rwesson commented 8 years ago

The weighting scheme is still hard coded but is now defined at the beginning of neat.f95, instead of being scattered throughout abundances.f95. Thus, reading it from a file will be easy to implement. Before doing that, I'll work on doing the same for abundances.

a491844f830757a71b60875cc1d8f430c92ae83c 7495ac0ab9c6da6c670fda0dad8f96ce4a29b679 8056dbb10bc77295586ead2b0e22e9fff7a217b5 284f511aaee179b0a70d278975c9d7594ee1409b

rwesson commented 8 years ago

Abundance weights now all specified in one place. Just the final step of reading them in from a file remains to do.

246e78ad23d2597e2a4a622f33d41041cdc40c89 00ba87fc829dab14d14a47af6312227f9e283a96

rwesson commented 8 years ago

Weights read in from file. Weighting for recombination lines still needs to be added. Individual line weightings for them would be excessive, I think, but possibility to exclude multiplets is desirable. 048fc37dcb6cc5f0d45f28de9fc4c0da644aa349

rwesson commented 8 years ago

Weights of NII and OII multiplets can now be configured. 85eb8678e280eb904c7ba5710257e56777ed78ca